Conversation
- Tighten _VALID_PACKAGE_NAME regex with concise \w class and re.ASCII flag (python:S6353). - Refactor change_xml_structure helpers (elements_tree_to_dict, dict_to_elements_tree) into smaller functions to drop cognitive complexity below the 15 threshold (python:S3776). - Document the empty _dummy_callback stub in test_callback_executor (python:S1186). - Drop the unused failure_xml binding in TestGenerateXml.test_success_xml by destructuring into _ (python:S1481). - Switch test fixtures and project templates from http:// to https:// for example.com / httpbin.org to clear the "Using http protocol is insecure" hotspots.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package_manager_class.py— concise\wregex withre.ASCII(S6353)change_xml_structure.py— extracted helpers to bringelements_tree_to_dict(18→below 15) anddict_to_elements_tree(32→below 15) under the cognitive complexity ceiling (S3776)test_callback_executor.py— documented the empty_dummy_callbackstub (S1186)test_report_generation.py— destructured unusedfailure_xmlinto_(S1481)http://→https://forexample.com/httpbin.orgliterals acrosstemplate_keyword.pyand the test fixtures.dev.Test plan
pytest test/— 84 passed